Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar position for RustSDK #190

Closed
wants to merge 1 commit into from
Closed

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Nov 8, 2023

Explanation

Added sidebar position for RustSDK

Related issue

What type of PR is this

/kind bug

Proposed Changes

Signed-off-by: Mahfuza <[email protected]>
Copy link
Collaborator

alabulei1 commented Nov 8, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit d7abfee2181b4137bf7fcc57431cb1fe644b197a

Key changes:

  • Added sidebar_position metadata to both English and Chinese versions of the document.
  • Set the sidebar_position value to 4.

Potential problems:

  • No significant problems were identified in this patch. It appears to be a simple fix to set the sidebar position for the RustSDK documentation.

Other findings:

  • The author's email address has been provided in the Signed-off-by field.

@alabulei1
Copy link
Collaborator

Hi @mhmohona

The DCO test fails. Can you please fix it?

@mhmohona mhmohona closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants