Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links to plugins #186

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Nov 3, 2023

Signed-off-by: Divyanshu GUpta <[email protected]>
Copy link
Collaborator

alabulei1 commented Nov 3, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

The two patches reviewed both involve adding or updating links to plugins in the documentation. There don't seem to be any potential problems or issues with either of the patches. They both appear to be straightforward and expected changes.

Details

Commit f396c38b45209979e278faec1b9ae834c05b8f5c

Key changes:

  • Added relative links to plugins in the docs/contribute/plugin/intro.md and docs/start/wasmedge/extensions/plugins.md files.

Potential problems:

  • There doesn't seem to be any potential problems with this patch. It simply adds links to plugins, which seems to be an expected change.

Commit cbb65fe906cb939a4ad71610910fef49ed6d8fea

Key changes:

  • Updated links for various plugins in the docusaurus-plugin-content-docs folder.

Potential problems:

  • None detected. The patch seems to be a straightforward update to the links in the documentation.

@Mash707
Copy link
Contributor Author

Mash707 commented Nov 3, 2023

Hi @hydai , please have a look at this. Thank you

Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mash707
Copy link
Contributor Author

Mash707 commented Nov 6, 2023

@Mash707 Could you please update the links here as well?

https://github.com/WasmEdge/docs/tree/main/i18n/zh/docusaurus-plugin-content-docs/current

Sure I'll update it

@Mash707 Mash707 force-pushed the adding-links-to-plugins branch from eaf4874 to cbb65fe Compare November 6, 2023 16:48
Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hydai Could you please take another look at this?

@hydai hydai merged commit bc006f9 into WasmEdge:main Nov 8, 2023
6 checks passed
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 10, 2023
* added relative links to plugins

Signed-off-by: Divyanshu GUpta <[email protected]>

* Updated links in the docusaurus-plugin-content-docs folder

Signed-off-by: Divyanshu GUpta <[email protected]>

---------

Signed-off-by: Divyanshu GUpta <[email protected]>
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 10, 2023
* added relative links to plugins

Signed-off-by: Divyanshu GUpta <[email protected]>

* Updated links in the docusaurus-plugin-content-docs folder

Signed-off-by: Divyanshu GUpta <[email protected]>

---------

Signed-off-by: Divyanshu GUpta <[email protected]>
ezirmusitua pushed a commit to ezirmusitua/WasmEdge_docs that referenced this pull request Nov 19, 2023
* added relative links to plugins

Signed-off-by: Divyanshu GUpta <[email protected]>

* Updated links in the docusaurus-plugin-content-docs folder

Signed-off-by: Divyanshu GUpta <[email protected]>

---------

Signed-off-by: Divyanshu GUpta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants