-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve precommit issue #115
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lucif3r-in <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit c6311aec7723d21e150ae4fa4166e07868301d66Key changes:
Potential problems:
|
@Lucif3r-in I dont think this scrip will work, It should be something like this, The above is just an example, more info: https://www.npmjs.com/package/lint-staged & https://github.com/okonet/lint-staged |
Also lint check seems to fail here, https://github.com/WasmEdge/docs/actions/runs/5312158635/jobs/9616295701?pr=115 👀 |
How do I make sure what files to check for eslint? |
|
Here, I guess I had to run prettier --check |
Look at the suggested changes its already ensuring eslint runs if .ts or .tsx files is changed here you can add js and jsx file here additionally |
I think this is not a suggested change. It was an example, we have to look at the codebase and make changes accordingly. I am working on it. Thanks |
Please check the CI checks. The Lint failed. Thanks. |
Fixes #99
Added lint-staged to package.json as lint-staged was failing during commit
Removed cspell as the flag of cspell was raised even if there was no error.
@adithyaakrishna Please look into it.