netplay: some more IClientConnection improvements (safety and completeness)
#4210
+100
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManManson
changed the title
IClientConnection improvementsIClientConnection improvements (safety and completeness)
This method is generic enough to be lifted to the `IClientConnection` level since it only relies on the following two things: 1. `IDescriptorSet` implementation, provided by the parent `WzConnectionProvider` 2. `recvImpl()` method from a concrete implementation of `IClientConnection` Signed-off-by: Pavel Solodovnikov <[email protected]>
Mark `IClientConnection` destructor as `protected`, so that external code cannot accidentally invoke `delete` on a connection object directly, and thus is forced to call `close()` method on it for safe disposal. Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
netplay_client_connection_refactoring_02_2025
branch
from
c5f8d78 to
c0046b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset contains the following two fixes:
IClientConnectionas generic as possible by movingreadAll()implementation fromTCPClientConnectiontoIClientConnectionleveldeleteon a connection instance directly and has to useIClientConnection::close(), which will ensure that connection disposal is performed in a safe way (i.e. doesn't interfere withPendingWritesManager).