Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the translation map for unix system locale #3708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CupnPlateGames
Copy link
Contributor

This patchs looks for an acceptable entry when using the System locale (from environment variables) to have the same behaviour as when selecting a locale explicitely.

How to reproduce, before the patch:

  • install a locale on your system that is not English and supported by Warzone 2100, set it as your system locale (for example fr_FR, de_DE or ru_RU)
  • relog, check your locale with locale
  • Run the game, it should be translated when you select the language in the settings, but still be in English with System locale

How to test, after the patch:

  • With your system still in the non-English locale
  • Run the game, it should be translated with System locale
  • You can try an alternative locale like de_BE and it should still be in German (unless the locale de_DE is not installed which is an other issue)

@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
@KJeff01 KJeff01 added this to the 4.6.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants