Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use universal vs app scheme links when possible #65

Closed

Conversation

mooshee
Copy link

@mooshee mooshee commented Mar 21, 2024

Description

Resolves #64

How Has This Been Tested?

  1. Supply a universal and native link in the AppMetadata
  2. Toggle the preferUniversalLinks flag
  3. Launch a wallet

@mooshee
Copy link
Author

mooshee commented Mar 22, 2024

Not sure this works for all wallets at the moment. Started this PR as a conversation started to see the appetite for moving this direction. Most native SDKs (Coinbase, Phantom, SolFlare, to name a few) are going this route because it's more reliable, secure and a better user experience.

@bkrem
Copy link
Member

bkrem commented Mar 22, 2024

Hey @mooshee, thank you for jumping in with the contribution 💪 Wanted to note that @llbartekll is OOO Thu/Fri, we'll get back to you here on Monday when he's back 🙏

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chichkanov
Copy link

hey guys, any update on this?

@llbartekll
Copy link
Collaborator

hey @mooshee, thank you for your contribution.

it's more reliable, secure and a better user experience.

I couldn't agree more, but the problem is that historically, universal linking hasn't worked very well due to flawed integrations. There have been many cases where users ended up in the App Store or Safari instead of the intended destination. When a dApp connects to a single wallet, it’s simple to rely on. However, in the case of W3M, where you have hundreds of wallets, it's not that simple. Regardless, we will definitely provide an alternative soon.

@mooshee
Copy link
Author

mooshee commented Apr 2, 2024

Ostensibly, all dapps and wallets should have their universal links defined in the wallet connect registry. It would make sense to allow us to override the registry with the local metadata configuration.

Good to know you're working on it. Thanks for the update!

@mooshee mooshee closed this Apr 2, 2024
@mooshee mooshee deleted the prefer-universal-links branch September 20, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use universal instead app scheme links
4 participants