Network detail screen #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
reviewed
Nov 9, 2023
| public struct CircleProgressView: UIViewRepresentable { | ||
|
|
||
| public struct DrawingProgressView: UIViewRepresentable { | ||
| var shape: DrawingProgressUIView.ShapePath | ||
| var color: Color |
flypaper0
reviewed
Nov 9, 2023
| case let .response(value): | ||
| let stringResponse = try? value.get(String.self) | ||
|
|
||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
you receiving on main queue as I see. Why DispatchQueue async needed here?
flypaper0
reviewed
Nov 9, 2023
| try? await self.addEthChain(from: from, to: chain) | ||
| } | ||
| } else { | ||
| DispatchQueue.main.async { |
flypaper0
reviewed
Nov 9, 2023
|
|
||
| self.triedAddingChain = false | ||
| self.switchFailed = false | ||
| Task { @MainActor in |
There was a problem hiding this comment.
I'm not sure that switchChain will be executed on main thread. You should mark switchChain method with @mainactor ig
flypaper0
reviewed
Nov 9, 2023
|
|
||
| DispatchQueue.main.async { | ||
| self.store.selectedChain = ChainPresets.ethChains.first(where: { $0.chainReference == String(chainReference) }) | ||
| self.router.setRoute(Router.AccountSubpage.profile) |
flypaper0
reviewed
Nov 9, 2023
|
|
||
| DispatchQueue.main.async { | ||
| self.store.selectedChain = chain | ||
| self.router.setRoute(Router.AccountSubpage.profile) |
flypaper0
reviewed
Nov 9, 2023
| var body: some View { | ||
| VStack { | ||
| content() | ||
| .onAppear { |
There was a problem hiding this comment.
may be .task{ } will be enough here? It also has async context so no need to create extra Tasks
There was a problem hiding this comment.
but .task is executing on first view load only
There was a problem hiding this comment.
Yeah but it is also iOS 15+
radeknovis
force-pushed
the
feat/network-detail
branch
from
8cc2cbe to
924f1ff
Compare
alexander-lsvk
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains rerecorded snapshots for Xcode 15/ iOS 17