chore: consolidate signal handling #302
Open
+49
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g' into chore/consolidate_signal_handling
xDarksome
reviewed
Nov 25, 2025
…g' into chore/consolidate_signal_handling
heilhead
approved these changes
Nov 27, 2025
| /// | ||
| /// Note: this function does not care whether `f` and `shutdown_signal` are | ||
| /// connected or not. The caller must ensure they are. | ||
| pub async fn run_with_signal_handling<F, E: From<io::Error>>( |
Collaborator
There was a problem hiding this comment.
Are you sure that wcn_rpc is the best place for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the db and node signals handling into a single function that is then used by the respective mains.
Resolves WCN2-79