refactor: replaced stablelib with noble libs #216
Merged
+1,093
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
devceline
approved these changes
Jan 15, 2025
Comment on lines
3
to
5
| export function randomBytes(length: number): Uint8Array { | ||
| const buf = crypto.randomBytes(length); | ||
| return bufferToArray(buf); | ||
| return rb(length); | ||
| } |
There was a problem hiding this comment.
We don't need this method anymore
Comment on lines
23
to
33
| export function fallbackSha256(msg: Uint8Array): Uint8Array { | ||
| const result = hash.sha256().update(msg).digest(HEX_ENC); | ||
| return hexToArray(result); | ||
| return sha256(msg); | ||
| } | ||
|
|
||
| export function fallbackSha512(msg: Uint8Array): Uint8Array { | ||
| const result = hash.sha512().update(msg).digest(HEX_ENC); | ||
| return hexToArray(result); | ||
| return sha512(msg); | ||
| } | ||
|
|
||
| export function fallbackRipemd160(msg: Uint8Array): Uint8Array { | ||
| const result = hash.ripemd160().update(msg).digest(HEX_ENC); | ||
| return hexToArray(result); | ||
| return ripemd160(msg); | ||
| } |
There was a problem hiding this comment.
These methods are no longer needed
Cali93
approved these changes
Jan 16, 2025
|
@ganchoradkov I suggest to use newly released 1.7.1 and 1.2.1. These will be used in ethereum-cryptoraphy so you will benefit from deduplication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #185, opened new PR due to conflicts in the initial PR
Replaced
aes-js->@noble/ciphershash.js->@noble/hashes@stablelib/x25519->@noble/curves@stablelib/ed25519->@noble/curvesrandombytes->@noble/hashesCanaries
@walletconnect/[email protected]@walletconnect/[email protected]@walletconnect/[email protected]@walletconnect/[email protected]