-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase tracing options #360
Conversation
Great, for the SM I can now reproduce the results we had in the draft earlier. |
Also the model file from one of the beta testers that we had trouble with earlier works without modifications, which is very good! |
I actually don't know what version of the code the SM results in our paper were produced with. I thought that they weren't produced with v1.0.0 but I could be wrong. |
No, indeed, the graph was not made with v.1.0.0. |
Looks to me like v1.0.0 is equivalent to See: WallGo/src/WallGo/freeEnergy.py Line 340 in aa3f43e
|
Ahhhh now I see why I was confused. For the SM it is actually set to None, not to 1.0. None is indeed the right value, so I was confused why this would work with 1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works very well, I have tested it for all BM models. Thanks a lot!
Thanks Jorinde for your comments. This helped me realise that the loading of the new config parameter wasn't working (so all were using the default None). This has now been fixed. |
Added one option for setting the first step size in phase tracing. Option can be fixed with config.
In the model files, I've put the option to
None
for all the models except the Standard Model, where I have set it to1.0
. Is this correct? I couldn't quite remember.