Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jevois module generation for python #872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rrossbach
Copy link

This PR adds the option to generate an elementary jevois module as part of code generation for the pipeline. This helps simplify use of GRIP pipelines on the jevois.

Currently only Python is supported, and the module is very elementary. The module will:

  1. execute the generated GRIP pipeline
  2. if USB streaming is enabled, stream the input image to the host. If the last step of the GRIP pipeline produced contour output, draw the contours on the input image

@rrossbach rrossbach force-pushed the jevoisCodeGeneration branch 4 times, most recently from c484663 to d6eec30 Compare December 23, 2017 19:35
@codecov-io
Copy link

codecov-io commented Dec 23, 2017

Codecov Report

Merging #872 into master will decrease coverage by 0.18%.
The diff coverage is 10.25%.

@@             Coverage Diff              @@
##             master     #872      +/-   ##
============================================
- Coverage     51.71%   51.52%   -0.19%     
  Complexity     1158     1158              
============================================
  Files           247      247              
  Lines          7812     7850      +38     
  Branches        533      539       +6     
============================================
+ Hits           4040     4045       +5     
- Misses         3591     3622      +31     
- Partials        181      183       +2

@@ -24,23 +24,26 @@
<rowConstraints>
<RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" />
<RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" />
<RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="NEVER" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't aligned correctly. Tabs vs spaces?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm possibly. I didn't edit that file manually so I guess SceneBuilder didn't align. I'll update manually

outframe.sendCvBGR(img)

# TODO: send contour report over USB
# TODO: add parameter(s) to enable/disable individual values of the report over USB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to do this before this is merged?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to yes - I also have some refactoring in the template I'd like to include (using socket type rather than name to determine whether or not to generate the drawing code). I'll amend the commit over the next couple of days; please let me know if any other thins to look at as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants