Feat: Add edit button for user hours on event detail#662
Open
benjamin-antupit wants to merge 1 commit into
Open
Feat: Add edit button for user hours on event detail#662benjamin-antupit wants to merge 1 commit into
edit button for user hours on event detail#662benjamin-antupit wants to merge 1 commit into
Conversation
benjamin-antupit
force-pushed
the
582-single-add-button-redirects-to-bulk-add
branch
from
30e69a9 to
952f4b4
Compare
Adds an edit button (and page) to the event detail mega page. Edit page shows all user hour instances for event and allow editor to add additional instances or delete instance(s).
benjamin-antupit
force-pushed
the
582-single-add-button-redirects-to-bulk-add
branch
from
b6af4e0 to
d0eecf0
Compare
tnurse18
reviewed
Jun 4, 2022
| category = ModelChoiceField(queryset=Category.objects.all(), required=False) | ||
| service = ModelChoiceField(queryset=Service.objects.all(), required=False) # queryset gets changed in constructor | ||
|
|
||
| class MKSingleHoursForm(forms.ModelForm): |
Member
There was a problem hiding this comment.
If I remember correctly, there was already a view for this so creating this form may be redundant. The more forms we can reuse, the better.
Contributor
Author
There was a problem hiding this comment.
The only single-instance hour form that I could find is tied to an individual user and based on Event2012. I based this one off of the bulk hours one and I could combine them, but I figured this would be easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an edit button (and page) to the event detail mega page (currently under the
Reportstab). Edit page shows all user hour instances for event and allow editor to add additional instances or delete instance(s).