feat: 약관동의 html 제공 기능 및 user 약관동의 저장 기능 추가 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughAdds a complete “Terms” module: JPA entities, DTOs, repositories, services, and REST controllers for fetching latest terms by type and recording user agreements. Introduces a new error code TERMS_NOT_FOUND and integrates authentication principal usage for agreement submission. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant TermsController as TermsController (/api/terms)
participant TermsService as TermsService
participant TermsRepo as TermsRepository
participant BaseResponse as BaseResponse
Client->>TermsController: GET /api/terms?type=TERMS_OF_SERVICE
TermsController->>TermsService: getLatestTerms(type)
TermsService->>TermsRepo: findFirstByTypeOrderByEffectiveDateDescVersionDesc(type)
alt Terms exists
TermsRepo-->>TermsService: Terms
TermsService-->>TermsController: TermsResponseDto
TermsController-->>Client: 200 BaseResponse{data=TermsResponseDto}
else Terms missing
TermsRepo-->>TermsService: Optional.empty
TermsService-->>TermsController: throw CustomException(TERMS_NOT_FOUND)
TermsController-->>Client: Error response
end
sequenceDiagram
autonumber
actor Client
participant TermsAgreementController as TermsAgreementController (/api/terms-agreement)
participant TermsAgreementService as TermsAgreementService
participant UserRepo as UserRepository
participant TermsRepo as TermsRepository
participant UTARepo as UserTermsAgreementRepository
Client->>TermsAgreementController: POST /api/terms-agreement\nAuthorization: Bearer ...\nBody: { agreedTermsIds: [...] }
TermsAgreementController->>TermsAgreementService: agreeToTerms(principal, request)
TermsAgreementService->>UserRepo: findById(principal.userId)
alt User found
UserRepo-->>TermsAgreementService: User
TermsAgreementService->>TermsRepo: findAllById(agreedTermsIds)
alt All IDs resolved
TermsRepo-->>TermsAgreementService: List<Terms>
TermsAgreementService->>UTARepo: saveAll(List<UserTermsAgreement>)
TermsAgreementService-->>TermsAgreementController: void
TermsAgreementController-->>Client: 200 BaseResponse{message="약관 동의가 성공적으로 처리되었습니다."}
else Missing/invalid IDs
TermsRepo-->>TermsAgreementService: Partial/empty
TermsAgreementService-->>TermsAgreementController: throw CustomException(TERMS_NOT_FOUND)
TermsAgreementController-->>Client: Error response
end
else User missing
UserRepo-->>TermsAgreementService: empty
TermsAgreementService-->>TermsAgreementController: throw CustomException(USER_NOT_FOUND)
TermsAgreementController-->>Client: Error response
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (12)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
feat: 약관동의 html 제공 기능 및 user 약관동의 저장 기능 추가
📸 기능 스크린 샷 공유
💬 공유사항 to 리뷰어
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Summary by CodeRabbit