Skip to content

fix(invoice): reject expires_in_seconds above MAX_EXPIRY_SECONDS and …#161

Merged
misrasamuelisiguzor-oss merged 1 commit into
WHEELBACK:mainfrom
yahia008:fix/invoice-max-expiry-and-metadata-check
Jun 26, 2026
Merged

fix(invoice): reject expires_in_seconds above MAX_EXPIRY_SECONDS and …#161
misrasamuelisiguzor-oss merged 1 commit into
WHEELBACK:mainfrom
yahia008:fix/invoice-max-expiry-and-metadata-check

Conversation

@yahia008

Copy link
Copy Markdown
Contributor

Closes #12
Closes #10

…validate metadata_hash on mark_paid

- Call require_expiry_not_too_long in create_invoice (closes WHEELBACK#10)
- Add provided_metadata_hash param to mark_paid with MetadataMismatch guard (closes WHEELBACK#12)
@drips-wave

drips-wave Bot commented Jun 25, 2026

Copy link
Copy Markdown

@yahia008 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@misrasamuelisiguzor-oss
misrasamuelisiguzor-oss merged commit 85ed08d into WHEELBACK:main Jun 26, 2026
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(invoice): add metadata_hash integrity check on mark_paid fix(invoice): prevent ExpiryOverflow panic from reaching contract storage

2 participants