Feat/add bulk allow addresses entrypoint#157
Closed
whisper011 wants to merge 0 commit into
Closed
Conversation
|
@whisper011 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
whisper011
force-pushed
the
feat/add-bulk_allow_addresses-entrypoint
branch
from
June 26, 2026 15:51
97a6400 to
2f968f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(compliance): Add bulk_allow_addresses entrypoint that atomically onboards a batch of addresses to the allowlist in a single transaction, reusing the per-address allow logic and emitting an address_allowed event for each entry.
feat(compliance): Add bulk_block_addresses entrypoint that blocks a batch of addresses in a single transaction, following the same emergency policy as block_address (permitted while paused) and emitting an address_blocked event for each entry.
test(compliance): Add regression test block_flag_overrides_allow_flag_in_is_allowed that explicitly documents and guards the invariant that a Blocked = true flag takes precedence over Allowed = true in is_allowed.
chore(treasury): Extract contracts/treasury/src/multisig.rs and settlement.rs into a new crates/multisig workspace crate (comebackhere-multisig). Treasury now depends on the crate and imports types/helpers directly from it. The workspace Cargo.toml is updated to include the new member.
Test plan
cargo test -p comebackhere-compliance — all existing compliance tests pass; new bulk entrypoints and block-overrides-allow test covered
cargo test -p comebackhere-treasury — treasury tests pass after multisig extraction; re-exported types remain accessible as treasury::{Settlement, TreasuryError, …}
cargo build -p comebackhere-multisig — new crate builds cleanly as a standalone workspace member
Closes #60
Closes #61
Closes #62
Closes #63