feat(compliance): add revoke_allow entrypoint for soft de-listing#134
Merged
misrasamuelisiguzor-oss merged 2 commits intoJun 25, 2026
Merged
Conversation
|
@Phantomcall Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: feat(compliance): add revoke_allow entrypoint for soft de-listing
Summary
Adds
revoke_allow(env, admin, address)— a new entrypoint that removes theAllowedflag and anyAllowedUntilexpiry from an address without setting theBlockedflag. This enables operators to de-list an address from the allowlist without placing it on the blocklist.Motivation
Previously, the only way to remove an address from the allowlist was:
block_address— setsBlocked = true, marking the address as maliciousclear_address— setsBlocked = false, Allowed = true, which re-allowsNeither provides a clean "remove from allowlist but don't accuse" path.
revoke_allowfills this gap for addresses that are no longer active but not suspected of wrongdoing.Implementation
contracts/compliance/src/lib.rs: Newrevoke_allowfunction inComplianceContract:require_adminrequire_not_pausedDataKey::AllowedandDataKey::AllowedUntilfrom persistent storageexport_snapshotcaptures the state transition)address_revokedeventTests added
All in
contracts/compliance/tests/compliance_test.rs:revoke_allow_removes_allowed_statusis_allowedreturnsfalserevoke_allow_does_not_blockrevoke_allow_removes_expiryis_allowedreturnsfalse, can re-allowrevoke_allow_returns_unauthorized_for_non_adminContractError::Unauthorizedrevoke_allow_returns_contract_paused_when_pausedContractError::ContractPausedVerification
All 40 tests pass:
cargo test --package comebackhere-complianceCloses #76