Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main scene fix #2256

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

main scene fix #2256

wants to merge 1 commit into from

Conversation

cawke
Copy link
Collaborator

@cawke cawke commented Jan 21, 2025

dont merge.

@fwild first need to test this fix on vision os. not sure how it will work.

fixes for event systems. allows testing UI with mouse (without these changes clicking doesn't work at least for me and @AKissMail) and interacting with objects using controller simulators.

I thought that the problem with event system was only mine, that's why I didn't commit them earlier.

image

@fwild
Copy link
Collaborator

fwild commented Jan 23, 2025

I have tested the build from Herman now as well, this is what I found:

  • it seems the volume camera setup has changed, and MirageXR now starts non-exclusive (= you can see the other windows like TestFlight that I had open still, while MirageXR is open). That's per see not a totally bad thing, but it needs a discussion, whether we want that - should not affect the interaction use in any case.
  • I can see dark (=cutout) virtual hands, but at the same time the VisionOS cutouts around my hands are not visible. I think this is because we switched to the other Volume Camera setting? Or is this because we activated hands visualisation? They are clearly cut off hands, whereas the native apple support for upper limb visibility would not only cut out the "glove" shape, but the full arm
  • interaction works
  • interaction did not work on the toggle button of the collaboration window and not on the view/edit toggle, so I could not see how the virtual hands cutout works together with the avatar visualisation (I guess it does not fit well, but could not test it)

So: overall, it seems to work, but we should discuss the virtual hands and the volume camera setting, and we should make sure that the new events (?) are assigned to every UI element.

That's my five pence.

@cawke cawke marked this pull request as draft January 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants