fix(netif): prevent out of bounds carp configuration #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELDiablO59152
commented
Jan 22, 2026
| ) | ||
|
|
||
| priority = priority + 50 | ||
| priority = priority + prio_increment |
Member
Author
There was a problem hiding this comment.
I'm not sure if it's the best way to ensure a decent amount of priority level, but all network address priority will be overridden each time a new nic is added to the carp configuration.
ELDiablO59152
commented
Jan 22, 2026
| {{form.carp_vhid}} | ||
| {{form.carp_vhid.errors}} | ||
| </div> | ||
| <div class="form-group" id="container_carp"></div> |
Member
Author
There was a problem hiding this comment.
This container is never used.
ELDiablO59152
commented
Jan 22, 2026
|
|
||
| }).trigger('change') | ||
|
|
||
| $('#netif_edit_form').on('submit', function(e){ |
Member
Author
There was a problem hiding this comment.
This event listener was broken.
ELDiablO59152
force-pushed
the
fix_carp_priority
branch
from
f58d1e6 to
8a58ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed