add(services): output queues in default rulesets #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELDiablO59152
force-pushed
the
add_outputs_to_default_rulesets
branch
2 times, most recently
from
c101a1a to
30eecae
Compare
frikilax
reviewed
Oct 22, 2025
Comment on lines
92
to
+102
| {{ frontend.log_condition }} | ||
|
|
||
| action(type="omfile" DynaFile="recoveryfile" CreateDirs="on" action.ExecOnlyWhenPreviousIsSuspended="on" template="raw_message") | ||
| call {{ frontend.ruleset_name }}_outputs |
Member
There was a problem hiding this comment.
can't keep {{ frontend.log_condition }} if you call the outputs ruleset with the same action inside
Comment on lines
-115
to
-116
| set $!frontend_name = "{{frontend.name}}"; | ||
|
|
| }-%} | ||
|
|
||
| ruleset(name="{{ frontend.ruleset_name }}_outputs" queue.type="Direct") { | ||
| {{ frontend.log_condition|indent(4, false) }} |
Member
There was a problem hiding this comment.
why is this one indented? (and not the other?)
Comment on lines
+107
to
+109
| # Convert timestamp from epoch to rfc3339 | ||
| set $!timestamp = replace(format_time(field($!time, ".", 1), "date-rfc3339"), "Z", "." & field($!time, ".", 2) & "Z"); | ||
|
|
Comment on lines
+15
to
+17
| ruleset(name="{{ frontend.ruleset_name }}_outputs_garbage" queue.type="Direct") { | ||
| {{ frontend.log_condition_failure|indent(4, false) }} | ||
| } |
ELDiablO59152
force-pushed
the
add_outputs_to_default_rulesets
branch
from
30eecae to
d63e9da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added