Merged
Conversation
* Added Flyway core and MySQL dependencies in build.gradle * Enabled Flyway in application configurations for both production and default profiles * Configured Flyway settings including baseline and validation options This update facilitates database version control and migration management.
* Deleted CountryInitializer and DataInitializer classes as they are no longer needed. * Added initial SQL migration scripts for database schema and basic data setup, including country, emotion, weather, trip theme, and user data. This cleanup streamlines the initialization process and leverages database migrations for data management.
…dGenerateTokens method * Refactored LoginServiceTest to replace login method with loginAndGenerateTokens. * Updated assertions to reflect changes in response structure. * Adjusted test data and mock setups in LoginControllerTest for consistency. * Removed deprecated init tests in CountryServiceTest as they are now handled by Flyway migrations. * Added Clock mocking in AlarmPolicyServiceTest and AlarmServiceTest for consistent time handling.
…ion handling * Replaced when().thenThrow() with doThrow().when() for better readability and clarity in the test setup. * This change enhances the exception handling in the test for invalid refresh tokens.
5 tasks
|
chwwwon
reviewed
Feb 4, 2026
Contributor
chwwwon
left a comment
chwwwon
left a comment
There was a problem hiding this comment.
고생하셨어요..!!!
수정할만한 사항은 없어보이니 아래 리뷰 하나만 확인해주시고 머지하면 될 것 같습니당
|
|
||
| -- DiaryImage 테이블 (FK: Diary) | ||
| CREATE TABLE IF NOT EXISTS `DiaryImage` ( | ||
| `DiaryImageId` BIGINT NOT NULL AUTO_INCREMENT PRIMARY KEY, |
Contributor
There was a problem hiding this comment.
혹시 여기서 DiaryImageId는 일부러 대문자로 시작하신건가용?
다른건 모두 첫글자 소문자로 시작되어서요!
Contributor
Author
There was a problem hiding this comment.
에, 왜 그것만 대문자인지 기억이 안 나네요... 흠 아마 원래 엔티티에 있던 컬럼명을 그대로 사용하느라 그런 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
📝 Description
목적
ddl-auto: update를 제거하고 Flyway로 스키마 버전 관리자세한 문서는 docs/flyway-migration 문서를 확인해주세요
🛠 Changes
ddl-auto: updateDataInitializer,CountryInitializerV2__insert_basic_data.sql,V3__insert_countries.sqlV4__test_user.sql(개발 전용)ddl-auto: validate+ Flyway 검증✅ Test Checklist