revised toggleable light mode/dark mode #293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the work of GadgetAngel, but revised for mantainability. Also draws on https://derekkedziora.com/blog/dark-mode-revisited
Contributor
|
do you want to incorporate anything from this most recent issue into this? |
Contributor
Author
|
I'm not sure any addition is necessary. (though the suggestion of making the color names a bit clearer is a good one). I think the original concept from GadgetAngel's version was to have the light theme be the color blind friendly one, which makes as much sense to me as anything... |
3 tasks
nemgrea
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of GadgetAngel, but revised for mantainability.
Also draws on
https://derekkedziora.com/blog/dark-mode-revisited
This may still need some tweaking. Primarily, I'm not happy with the current location of the dark/light toggle