feat: added new MMS types #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
============================================
- Coverage 84.52% 84.51% -0.02%
- Complexity 2819 2839 +20
============================================
Files 258 262 +4
Lines 7782 7838 +56
============================================
+ Hits 6578 6624 +46
- Misses 1204 1214 +10 ☔ View full report in Codecov by Sentry. |
superchilled
dismissed
their stale review
Having looked at the code snippet examples I have a question about the content type.
| public function toArray(): array | ||
| { | ||
| $returnArray = $this->getBaseMessageUniversalOutputArray(); | ||
| $returnArray['content'] = $this->content->toArray(); |
There was a problem hiding this comment.
Is this an array that can contain multiple content objects?
There was a problem hiding this comment.
Yea the content object will return an array of objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: