Fix/projects #108
Merged
Fix/projects #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anamontiaga
reviewed
Apr 10, 2024
| @@ -145,13 +145,17 @@ export default function ProjectDetailPanel() { | |||
| <div className="absolute left-0 top-0 w-full"> | |||
| {data && indicators && ( | |||
| <div className="relative"> | |||
| <Image | |||
| src={data.main_image?.data?.attributes?.url ?? '/images/projects/placeholder.png'} | |||
There was a problem hiding this comment.
so this placeholder.png can be removed from code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects filtering
Overview
The URL parameters are maintained when we navigate through the page. In most cases, this makes sense, but there may be situations where we do not want to keep those filters. This PR adds a setting to useQueryParams hook to provide flexibility to the function and keep only the parameters we want.
Also adds filtering to the projects layer.
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist