Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes/details ironed out. #45

Closed
wants to merge 11 commits into from
Closed

A few fixes/details ironed out. #45

wants to merge 11 commits into from

Conversation

jrcarl624
Copy link
Contributor

I apologize on the behalf of my formatter, maybe add a linter?

@Visual1mpact
Copy link
Owner

I apologize on the behalf of my formatter, maybe add a linter?

Definitely gonna need a linter to keep formatting under control lol. Our formatters are gonna create a lot of clutter real quick haha.

@Visual1mpact
Copy link
Owner

What did you use for your formatting? It made it difficult to review the commits for the actual changes in-between the lines.

@jrcarl624
Copy link
Contributor Author

jrcarl624 commented Jul 23, 2022

Prettier, I can re do the commits without formatting.

@jrcarl624
Copy link
Contributor Author

Also that I use " for strings and that auto formats.

@jrcarl624
Copy link
Contributor Author

I feel the best thing we can do here is set up es-lint with the npm package and have something in the package.json

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants