Skip to content

Conversation

@Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Oct 2, 2025

Supersedes #3879

@btomala I took your commits from #3879 and squashed them, to include the initial part of the fix & tests from your branch.
I will squash the whole thing when this PR gets merged.

TL;DR, what was happening:

  • resource directories from the test scope were added to 2 spots unnecessarily
  • one of those spots did not respect the scope, which caused the test scope resources to be on the main scope classpath
  • the "unnecessary" code adding the resources the second time put them on the elements list of inputs, which was then used to watch those directories under --watch (and made them necessary)
    • this is tidied up in the other commit
  • I added some more tests to cover some extra scenarios

@Gedochao Gedochao requested review from tgodzik and zielinsky October 2, 2025 08:25
… directives, while the resource directories' scope stays respected; add tests & refactor
@Gedochao Gedochao force-pushed the maintenance/test-resources-directive branch from b3f9521 to 0436edc Compare October 2, 2025 08:27
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @btomala for the contribution!

@Gedochao Gedochao enabled auto-merge (squash) October 2, 2025 09:10
@Gedochao Gedochao merged commit 236638c into VirtusLab:main Oct 2, 2025
104 of 106 checks passed
@Gedochao Gedochao deleted the maintenance/test-resources-directive branch October 2, 2025 19:49
@btomala
Copy link
Contributor

btomala commented Oct 3, 2025

Thank you two for the smooth cooperation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants