Update Voting.sol: Gas Optimizations #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our team will soon review your PR. Thanks @Aryan9592 :) |
|
LGTM. Thaks for this ssue. |
Vikash-8090-Yadav
merged commit 5a1ecae
into
Vikash-8090-Yadav:main
2 of 5 checks passed
|
Thank you @Aryan9592 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :) |
For sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Inefficient 'For' loops
👨💻 Changes proposed
Changed
uint256 i = 0;->uint256 i;, unsigned integers always have a default value of 0. Thus, it is a kind of waste of some gas to initialize variable to 0;Efficient
Forloops -> Above point is maintained here. Plusi++changed to++i, does the same work with less gas used upMy code follows the code style of this project.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.