Update TaskContract.sol #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Bound Check for array input. +In the getMyTasks function, there is no bounds checking when copying tasks into the temporary array. If the counter exceeds the temporary array's length, it could lead to an exception. We can add a check to ensure counter doesn't exceed temporary's length. > So , I updated the file with required changes.
|
@AVI-SHUKLA1110 what is your issue no.? |
|
I think I didn't create an issue for this, I just did the required changes in my forked repo |
|
@AVI-SHUKLA1110 then you should create an issue first and when it'll get assigned to you, then raise a pull request okay. |
|
Okayy thnks |
|
@shubhisingh184 the issue number is #503 |
|
@Vikash-8090-Yadav @shubhisingh184 please merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound Check for array input.
So , I updated the file with required changes.