Skip to content

Potential fix for code scanning alert no. 24: CORS misconfiguration for credentials transfer #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 24: CORS misconfiguration for credentials transfer #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/context/SharedContextServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,17 +168,24 @@ export class SharedContextServer extends EventEmitter {
'http://127.0.0.1:3000',
'http://127.0.0.1:3001',
'http://127.0.0.1:3002',
'http://127.0.0.1:3003',
'file://' // For local development tools
'http://127.0.0.1:3003'
// Removed 'file://' for security, do not allow it for credentialed CORS
];

if (allowedOrigins.includes(origin)) {
// Never allow "null" or "file://" as credentialed CORS origin
if (allowedOrigins.includes(origin) && origin !== "null" && origin !== "file://") {
res.setHeader('Access-Control-Allow-Origin', origin);
res.setHeader('Access-Control-Allow-Credentials', 'true');
} else if (origin.startsWith('http://localhost:') || origin.startsWith('http://127.0.0.1:')) {
// Allow any localhost port for development flexibility
} else if ((origin && (origin.startsWith('http://localhost:') || origin.startsWith('http://127.0.0.1:')))
&& origin !== "null" && origin !== "file://") {
// Allow development flexibility but never send credential header
res.setHeader('Access-Control-Allow-Origin', origin);
// Don't allow credentials for dynamic origins
res.setHeader('Access-Control-Allow-Credentials', 'false');
} else {
// For all other cases, do not reflect origin nor allow credentials
// Optionally, you could omit CORS headers entirely,
// or respond with a safe default:
res.setHeader('Access-Control-Allow-Origin', 'false');
res.setHeader('Access-Control-Allow-Credentials', 'false');
}

Expand Down
Loading