-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the other versions of dreamsim #156
Conversation
Happy to review but currently out of the office today (back tomorrow) so if it's okay to wait, I will gladly take a look then. No worries if you need to re-assign to anyone else. |
General thoughts (non-specific to this PR)Beyond that, it's a bit confusing to require the
If you specify anything different, you're informed:
... which isn't actually the case (as the Summary 👍In any case, I was able to get activations from the two additional models ( |
Thank you for your thorough review @Alxmrphi! I just updated both |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 30 30
Lines 1555 1555
Branches 222 222
=======================================
Hits 1139 1139
Misses 349 349
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR adds two new DreamSim models to
thingsvision
:dino_vitb16
and a DreamSimensemble
.