feat: Implement Dynamic Clawback Pro-Rata Recalculation#255
Merged
Conversation
|
@BarryArinze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Overview
This PR introduces dynamic pro-rata recalculation for partially clawed back vesting schedules.
Previously, if the DAO clawed back a portion of an allocation mid-stream, the remaining tokens could vest at the old emission rate, causing the schedule to end earlier than originally intended.
With this update, the contract recalculates the ongoing emission rate based on:
This ensures the vesting schedule still completes on its designated end date.
⚙️ Key Features
🏗️ Calculation Logic
At clawback time:
new_rate = adjusted_remaining_tokens / remaining_time
Future claims use the updated rate while honoring the original schedule end.
📐 Example
Original Schedule:
After 4 months:
DAO claws back 300 tokens.
Updated schedule:
Schedule still ends at month 10.
🔐 Safety Considerations
🧪 Testing
Added tests for:
🚀 Impact
🔗 Related Issue
Closes #198
🏷️ Labels
math, edge-case, finance