feat: add zero-divisor check — division by a parameter or storage value with no zero guard - #388
Merged
Merged
Conversation
feat: add zero-divisor check for unguarded division/remainder by parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381
Adds robust zero-guard validation prior to execution of division operations where the denominator is sourced dynamically from function parameters or contract storage.
Problem:
Performing division using dynamic values (such as user-supplied arguments or state-dependent storage variables) without a pre-flight zero check introduces a risk of runtime panics, arithmetic overflows, or transaction reversals.
Solution:
Enforce explicit checks to ensure denominators are strictly greater than zero before performing the operation. If a zero value is encountered, the transaction now gracefully fails with a clear, descriptive error code rather than triggering an unhandled panic.
Prevents edge-case runtime panics in arithmetic operations.
Improves error readability for client-side integration and debugging.