Slashing Condition Evidence Expiration Window Inconsistency Between Slot and Epoch Units#49
Merged
JamesEjembi merged 1 commit intoJul 18, 2026
Conversation
…s\n\n- Added evidence_infraction_slot_range to compute inclusive slot ranges for evidence\n- verify_evidence_expiry now compares earliest infraction slot against MAX_SLASHING_WINDOW (slots)\n- verify_surround_vote validates surround epochs and expiry\n- Added tests for boundary behavior and property test\n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13 \n\nSummary\n- Normalize slashing evidence expiry calculations to slots.\n- Add evidence_infraction_slot_range helper to compute inclusive slot ranges for evidence (epoch -> slot normalization).\n- verify_evidence_expiry now compares earliest infraction slot against MAX_SLASHING_WINDOW (in slots), treating the boundary as inclusive.\n- verify_surround_vote validates presence and ordering of source/target epochs and checks expiry.\n- Added tests: tests/slashing/evidence_expiry_test.rs (boundary and proptest property).\n\nFiles changed\n- src/slashing/evidence_verifier.rs (new)\n- src/slashing/mod.rs (export evidence_verifier)\n- tests/slashing/evidence_expiry_test.rs (new)\n\nTesting / validation performed (instructions to run locally)\n- Ensure Rust toolchain installed.\n- Run: cargo test --all\n- Check formatting: cargo fmt -- --check\n- The repository CI should run these commands; CI was not executed in this environment.\n\nBehavior notes and risks\n- Window semantics: evidence is considered valid when current_slot == earliest_start + MAX_SLASHING_WINDOW (inclusive). Change to exclusive expiry is trivial if desired.\n- No existing code behavior was modified beyond adding the verifier module and tests. Integration into slashing_core may be needed where existing expiry checks occur.\n\nSee: https://github.com/VeriNode-Labs/VeriNode--Core/issues/13\n\nCommit: 50aa41f