LastFM RPC: Option to hide art/album covers #3249
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new option to LastFMRichPresence plugin
"Always Hide Art"
- "Disable downloading album art"
This is a boolean which is checked at
getLargeImage()and skips returning the track's imageUrl, instead deferring to either the placeholder or null (lastfm logo) depending on other options.In essence, it acts as if all album art is impossible to find
Why
Last.fm art is uncensored. I would personally not like to flashbang whoever clicks on my profile with Death Grips' penis from the No Love Deep Web album, but that is not possible if I am using this plugin.
Spotify album art is censored, but Last.fm entries are not required to have Spotify links, so it would be unreliable. For now, a good solution is to allow the end user to disable album art entirely.