Chore/mark limit orders and nft orders as deprecated#229
Open
0xNazarii wants to merge 2 commits intofeat/deltaSlippageParamfrom
Open
Chore/mark limit orders and nft orders as deprecated#2290xNazarii wants to merge 2 commits intofeat/deltaSlippageParamfrom
0xNazarii wants to merge 2 commits intofeat/deltaSlippageParamfrom
Conversation
0xNazarii
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation/type-only JSDoc deprecations with no functional logic changes; main risk is downstream build noise or stricter linting on
@deprecatedusage.Overview
Marks the entire
limitOrdersandnftOrdersAPI surface as deprecated via JSDoc annotations on their exported types and handler constructors (approve/build/sign/post/get/cancel/tx helpers, plusconstructAll*Handlers).Propagates these deprecation notices up to the public SDK types in
src/sdk/full.tsandsrc/sdk/simple.ts, flagginglimitOrders/nftOrdersproperties and related fetch-method groupings as deprecated with planned future removal.Written by Cursor Bugbot for commit 93acd65. This will update automatically on new commits. Configure here.