Open
Conversation
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds a new external-order flow with EIP-712 signing, pre-signature transactions, and API posting, plus refactors shared slippage/partner-fee logic; mistakes could cause incorrect order parameters or signing/hashing mismatches.
Overview
Adds first-class support for External Delta orders: new builders, EIP-712 typed-data generation, signing, pre-signing (on-chain
setPreSignature), and posting viapostExternalDeltaOrder, plus a conveniencesubmitExternalDeltaOrderwired intoconstructAllDeltaOrdersHandlersand exported fromsrc/index.ts.Refactors Delta order construction by centralizing slippage/side/amount resolution and partner-fee encoding into shared helpers (
helpers/misc.ts), and updatesgetDeltaOrders/example status polling to handle both standard and external order shapes.Written by Cursor Bugbot for commit 4943d15. This will update automatically on new commits. Configure here.