Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function caller_sites verification in python api #6475

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

SmoothHacker
Copy link
Contributor

Fixes #3722

@psifertex
Copy link
Member

Thanks for the PR! It's a good idea however there's actually another approach we might need to implement but I'd have to double check the implementation. I believe the correct approach is to actually walk the IL in the first place of each caller_function and first check if it's an LLIL call and then return it. I'd have to dig up a sample that replicates it though to verify whether that is a better approach or not. Either way there's no reason not to at least add this.

Do you mind renaming x to ref though to be a bit more explicit? Super minor, sorry.

@SmoothHacker
Copy link
Contributor Author

No worries, I was tired when I made this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caller_sites is not reliable
2 participants