-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[TF2] Fixes for Exorcism spell not properly triggering #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Reckon you could fix Exorcism on stickybomb launchers and shields? |
Shields I believe I fixed, I just didn’t push it cause I haven’t been able to track down a spelled shield owner to test it. The stickybomb launchers I have no clue on what’s happening. It’s something happening with the particle being dispatched as even just having the particles being spawned on damage doesn’t work with the weapon. Although I still am digging into that issue. |
if i am not wrong you can just apply the spell to your or a bot weapon via Vscript, it's an attribute. |
I've actually never tinkered with VScript yet. Will look into it |
An easier solution is to use a modified item schema within the TF2 SDK and add the Exorcism spell as an attribute to any shield. |
I entirely forgot that the item schema was easily modifiable lmfao. I ended up adding the shield fixes. |
Great, now I wonder if we could ping Eric Smith to get these changes added into the vanilla game. |
|
Ok so, I have dug as deep as I can into the Stickybomb Launcher Exorcism issues, I do not believe I will be able to fix the issue with that weapon with this PR because from everything I have tested, it seems like it should work. From the testing I have done (relocating the particle effect code to on damage and other functions) the issue appears to stem from somewhere in the |
Within TF2, the Exorcism spell does not apply to any sentry kills when it is on the wrench. This PR fixes this issue alongside fixing the wrangler spells. This fix also applies to the sentry rockets.
The Exorcism spell also does not properly apply to shields within TF2. This is also fixed within this PR.
Fixes ValveSoftware/Source-1-Games#5018
Fixes ValveSoftware/Source-1-Games#4930