[ALL] Fix CVoiceStatus::UpdateServerState not sending the correct vban state from the client #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlaminSarge
changed the title
FlaminSarge
changed the title
FlaminSarge
changed the title
…e from the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An oversight would cause it to fetch only the lowest 32 players' infos instead of the correct index.
This would result in something like
vban 2 2 2 2instead ofvban 2 0 0 0when muting player 2 (muting player 34+66+98 in the process), and would prevent muting players above index 33 correctly as those would not send any vban.Tested with player indices >33 on live TF2 vs this patch: without the patch, muting player index 36 does nothing; with the patch the player gets muted properly. The outputs of voice_clientdebug and voice_serverdebug also print the expected (incorrect) values in live TF2 and (correct) values in patched version.