[TF2] 2 MvM Wavebar Changes #1289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updoot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes relating to the MvM wavebars.
The first change addresses issue #1226 where the change relating to red icon backgrounds didn't carry over to mission supports even though they were added for regular support bots.
The second change allows MvM mission creators to utilize their own tank icons, removing the hardcoded bits that forced the default tank icon, previously you needed an extension to get custom tank icons working and it wouldn't work for the boss bars. This also fixes a bug where if a wave uses the tank icon but doesn't have a tank would play the tank wave music on wave start, now it just checks if the wave has any tank spawns.