[TF2] Fix disguise bodygroups being tied to the disguise target #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently disguise wearables will set the disguise bodygroup of a disguised Spy based on the current model of the disguise target which causes the disguise to look incorrect if the disguise target changes models or disconnects.
This PR aims to fix this by making it based on the disguise players model and moving the code that does it to the client where the player has the correct model.
It will also always reset the disguise bodygroup when the bodygroup are recalculated.
Before:
2025-05-15.21-24-32.mp4
After:
2025-05-15.21-40-18.mov