[FEATURE/#16] 적금 상품 목록 조회 API 구현 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 15, 2026 01:27
seamooll
reviewed
Jan 16, 2026
Comment on lines
15
to
16
| @Value("${fss.auth-key}") | ||
| private String authKey; |
Contributor
There was a problem hiding this comment.
@value로 환경변수 주입하는 것보단 @ConfigurationProperties 설정 파일 활용하는 게 더 좋을 것 같습니다. baseUrl도 환경변수 처리 해주세요!
seamooll
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
📝 Summary
🔄 Changes
💬 Questions & Review Points
현재 금융 MBTI 기능이 아직 머지되지 않아 추천 로직 및 제미나이 연동은 포함되지 않습니다. 이번 PR에서는 금감원 OpenAPI 연동과 적금 상품 목록 조회 기능만 구현했습니다. 추후 금융 MBTI 기능이 반영되면, 추천 기능까지 확장할 예정입니다.
📸 API Test Results (Swagger)
✅ Checklist