Ковалёв Константин#5
Open
ARBUZNIJ wants to merge 11 commits into
Open
Conversation
Author
|
@NeiroYT, @ZhestkovaAnastasia, @SosnovskayaUlyana мою работу можно проверять |
NeiroYT
reviewed
May 2, 2024
NeiroYT
suggested changes
May 4, 2024
NeiroYT
left a comment
NeiroYT
left a comment
There was a problem hiding this comment.
Написал замечания, только красно-черные деревья особо не проверял, так как углубляться не захотел
| } | ||
| }; | ||
| Node* root; | ||
| TStack <Node*> way; |
There was a problem hiding this comment.
Является ли хорошим подходом хранить "временный" стек (в основном используемый для работы функций) прям в классе? Как минимум с точки зрения распараллеливания это как-то неудобно
Author
There was a problem hiding this comment.
Какие альтернативы? Выделение (первое обращение к) памяти при необходимости в методе - долго.
А если TStack :: clear() реализовать как просто обнуление size, то перевыделений памяти не будет совсем.
Author
|
@ValentinV95 , моя работа готова к проверке |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mentally prepared 4 yor criticism