Skip to content

build: use a lint.xml file for granular control over lint behavior#526

Merged
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom
lucasmz-dev:lint-xml
May 25, 2025
Merged

build: use a lint.xml file for granular control over lint behavior#526
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom
lucasmz-dev:lint-xml

Conversation

@lucasmz-dev
Copy link
Collaborator

allows us to ignore missingQuantity for specific languages, currently we have no plurals, though

also disabling missingTranslation

allows us to ignore missingQuantity for specific languages, currently we have no plurals, though

also disabling missingTranslation
@codecov
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (5676938) to head (7e8fc00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #526   +/-   ##
=========================================
  Coverage     95.26%   95.26%           
  Complexity      868      868           
=========================================
  Files           123      123           
  Lines          2618     2618           
  Branches        194      194           
=========================================
  Hits           2494     2494           
  Misses           44       44           
  Partials         80       80           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucasmz-dev lucasmz-dev requested a review from Copilot May 25, 2025 17:44
@lucasmz-dev
Copy link
Collaborator Author

(this feature just showed up for me)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes lint configuration by introducing a dedicated lint.xml file, enabling granular control over lint behavior. Key changes include:

  • Adding a new lint.xml file that specifies issues to ignore or treat as errors.
  • Updating build.gradle to reference the new lint.xml configuration.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/lint.xml Added a new lint configuration file to customize lint rule severities.
app/build.gradle Updated lint configuration to use the new lint.xml file instead of disabling rules inline.
Comments suppressed due to low confidence (2)

app/lint.xml:9

  • Consider verifying that setting MissingQuantity to 'error' is intentional. If the intent is to fully ignore missing quantity issues for certain languages, you might want to change the severity to 'ignore' or add a clarifying comment to avoid unintended build failures in locales not explicitly ignored.
<issue id="MissingQuantity" severity="error">

app/build.gradle:124

  • Ensure that the new lint.xml covers all necessary rule configurations previously managed by inline disable rules, so no lint checks are unintentionally missed.
lintConfig = file("app/lint.xml")

@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit bc7e32e into VREMSoftwareDevelopment:main May 25, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants