build: use a lint.xml file for granular control over lint behavior#526
Merged
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom May 25, 2025
Merged
Conversation
allows us to ignore missingQuantity for specific languages, currently we have no plurals, though also disabling missingTranslation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=========================================
Coverage 95.26% 95.26%
Complexity 868 868
=========================================
Files 123 123
Lines 2618 2618
Branches 194 194
=========================================
Hits 2494 2494
Misses 44 44
Partials 80 80 🚀 New features to boost your workflow:
|
Collaborator
Author
|
(this feature just showed up for me) |
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes lint configuration by introducing a dedicated lint.xml file, enabling granular control over lint behavior. Key changes include:
- Adding a new lint.xml file that specifies issues to ignore or treat as errors.
- Updating build.gradle to reference the new lint.xml configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/lint.xml | Added a new lint configuration file to customize lint rule severities. |
| app/build.gradle | Updated lint configuration to use the new lint.xml file instead of disabling rules inline. |
Comments suppressed due to low confidence (2)
app/lint.xml:9
- Consider verifying that setting MissingQuantity to 'error' is intentional. If the intent is to fully ignore missing quantity issues for certain languages, you might want to change the severity to 'ignore' or add a clarifying comment to avoid unintended build failures in locales not explicitly ignored.
<issue id="MissingQuantity" severity="error">
app/build.gradle:124
- Ensure that the new lint.xml covers all necessary rule configurations previously managed by inline disable rules, so no lint checks are unintentionally missed.
lintConfig = file("app/lint.xml")
VREMSoftwareDevelopment
approved these changes
May 25, 2025
bc7e32e
into
VREMSoftwareDevelopment:main
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows us to ignore missingQuantity for specific languages, currently we have no plurals, though
also disabling missingTranslation