Skip to content

Conversation

@lauriebax
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

Prevent training to error out on MLFlow logging exception. Instead of crashing, simply skip the log and continue training.

Modification

Try/catch around mlflow logging statements.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

No

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Jinior
Copy link
Collaborator

Jinior commented Jun 11, 2025

Can we make this a configurable option so the end-user can choose to keep the old behavior or ignore exceptions in logging?

@lauriebax
Copy link
Author

What should the default be? Crash on logging error or not?

@illyakaynov-vbti illyakaynov-vbti merged commit c4b550c into main Jun 17, 2025
@lauriebax lauriebax deleted the fix/make-mlflow-backend-more-stable branch July 9, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants