Remove future dependency and fix warnings #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test did not pass for me even after a clone and running fresh. I do not know if this is because of a version change in Sphinx or something. Help or advice on this would be appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly removes the stated dependency on the
futurepackage. It seemed to not be needed.In addition I have removed some of the warnings that were popping up when I ran the tests.
I have updated the output of one of the tests. When I freshly cloned the repo, it seemed that that test was failing. I am not sure if this is due to me have a different version of sphinx.
It is my first PR so advice on that would be appreciated.