feat: add projects page - #32
Conversation
✅ Deploy Preview for v1-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
todo: |
There was a problem hiding this comment.
Per slack, eventually we will have script to upload images to people-headshots bucket right?
There was a problem hiding this comment.
nope, not needed. the way that it works is that all the data downloading is done in the build step. notion api gives you a presigned url from s3 and the way that we can get around that link being ephemeral is that we literally just download the image to the public/ directory to serve as a static asset. while this isn't very scalable i don't think we'll encounter any issues for a long time
There was a problem hiding this comment.
I think the only issue with that would be updates for images. So at minimum app needs to be re-built every semester due to PS
There was a problem hiding this comment.
No im saying its not scalable because we're now storing a lot of images under the public directory lol
Rebuilding is as simple as redeploying in netlify
There was a problem hiding this comment.
Like im saying there needs to be some sort of trigger for rebuild on image update (either manual or automated)
There was a problem hiding this comment.
?
The data will be rebuilt when you trigger a redeploy Netlifys end
There was a problem hiding this comment.
Ya, this needs to be in docs then because people will need to trigger redeploy on netlify
There was a problem hiding this comment.
ah yeah i'll write it in the docs
if anything is broken / missing that's because there wasn't an entry in the notion DB or there was an incorrect entry. how do you wanna proceed with that info? |
i think hyperfan, DAWG, and Learn Bubble are literally just all too big. if you look in the db, they're all rectangular logos and not square |
i think this may be the wrong twinmind. all the founders are from UIUC 😭 |
we could but that's not actually how multi-select filtering by URL works. atp it's just syntatic sugar |
|
im deleting twinmind lmao |
|
@dllliu documentation done. everything else though is just like an issue with missing/incorrect data from the Notion db. If a founder is missing any information aside from name (linkedin/pfp), do we just wanna not display them? |
added a step to sanitize links from notion @dllliu. broken links should be fixed now unless the website is actually just non-existent |
If they have linkedin, we can use their linkedin pfp. But dont display the placeholder image if we really cant get their photo |
We could also comma delineate but then there would be backend parsing |
Im already using their LinkedIn pfp. Should i just not even show the founder if they have no pfp? |
I'd rather not do that. Extra complexity |
Can we resize? |
The the logos will be small as hell 😭 |
two options here, we can either use linkedin default image or not show founder image (but still have name and linkedin) |
2nd option will look weird if there's someone with a picture but one without. I'll just use the default linkedin pfp |
|
Do you think we should have people crop company logos to be square then? Because for startup week quite a few logos are rectangular |
|
Also once we make the change for vertical layout for page redesign we can have link to /projects in Product Studio subpage |
Other than this LGTM |
Yes |
draft pr