Skip to content

Fix various bugs and perform code cleanup #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
V10lator wants to merge 5 commits into from
Closed

Fix various bugs and perform code cleanup #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e94a062
Fix various bugs and perform code cleanup
google-labs-jules[bot] Feb 22, 2026
914d661
Fix various bugs and perform code cleanup
google-labs-jules[bot] Feb 22, 2026
0f5663c
Fix various bugs and perform code cleanup (Address build errors)
google-labs-jules[bot] Feb 22, 2026
be1024b
Final fix: Address all PR feedback and CI failures
google-labs-jules[bot] Feb 23, 2026
51d126b
Fix various bugs and typos
google-labs-jules[bot] Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/cfw.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/crypto.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/deinstaller.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/downloader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
4 changes: 1 addition & 3 deletions include/filesystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand All @@ -39,8 +39,6 @@ extern "C"
void deinitFS(bool validCfw) __attribute__((__cold__));
FSAClientHandle getFSAClient() __attribute__((__hot__));
NUSDEV getUSB();
void claimSpace(NUSDEV dev, uint64_t size);
void freeSpace(NUSDEV dev, uint64_t size);

@V10lator V10lator Feb 23, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you prove removing these functions does not introduce regressions? So have you checked why they have been added in the first place?

uint64_t getFreeSpace(NUSDEV dev);
bool checkFreeSpace(NUSDEV dev, uint64_t size);
uint64_t getSpace(NUSDEV dev);
Expand Down
2 changes: 1 addition & 1 deletion include/gtitles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/input.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/installer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/ioQueue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/keygen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/localisation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. * *
* with this program; if not, see <http://www.gnu.org/licenses/>. * *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/download.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/filebrowser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/installer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/insttitlebrowser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/logs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/main.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/predownload.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/titlebrowser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/update.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/menu/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/messages.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/no-intro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/notifications.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/osdefs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/otp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
4 changes: 2 additions & 2 deletions include/queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down Expand Up @@ -72,7 +72,7 @@ extern "C"
int addToQueue(TitleData *data);
bool removeFromQueue(uint32_t index);
void clearQueue();
bool proccessQueue();
bool processQueue();
LIST *getTitleQueue();

#ifdef __cplusplus
Expand Down
2 changes: 1 addition & 1 deletion include/renderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/romfs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/sanity.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/staticMem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/swkbd_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
2 changes: 1 addition & 1 deletion include/thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, If not, see <http://www.gnu.org/licenses/>. *
* with this program; if not, see <http://www.gnu.org/licenses/>. *
***************************************************************************/

#pragma once
Expand Down
Loading