fix(analytics): validate range parameter and return 400 for unsupport… - #869
Open
jikrana1 wants to merge 1 commit into
Open
fix(analytics): validate range parameter and return 400 for unsupport…#869jikrana1 wants to merge 1 commit into
jikrana1 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #858
Problem description
The
getTrendsendpoint currently falls back to the defaultdailyrange whenever an unsupported range value is provided (e.g.,?range=yearly). This silent fallback hides client-side mistakes and makes debugging more difficult because invalid requests still return successful responses.Proposed solution
Added explicit validation for the
rangequery parameter.Implementation details:
rangeis present and not inANALYTICS_RANGES(daily,weekly,monthly).400 Bad Requestwith a clear error message listing the supported values.rangeis not provided, keep the existing default behavior (daily).Benefits
Testing instructions
/analytics/trends?range=yearly. Should return a400 Bad Requesterror./analytics/trends?range=daily. Should return the daily trends normally./analytics/trendswithout anyrange. Should still default todailyand return data.