Bring every prediction path under the hot-reload swap - #1041
Merged
Userunknown84 merged 2 commits intoAug 1, 2026
Conversation
The URL classifier lived in module globals and mailbox scanning read objects pinned on the application at startup, so a reload refreshed some prediction paths and left others on the model the process booted with.
|
@pavsoss is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@pavsoss merge conflict h fix it fastly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A hot reload atomically swapped the text classifier, but two prediction paths sat outside it: the URL classifier was loaded once into module state, and mailbox scanning read model objects pinned on the application at startup. After a reload those paths kept serving whatever the process booted with, so a swap updated some paths and not others — the same class of defect as train-serve skew, arrived at from a different direction.
Closes #1037.
Changes
Both now travel in the versioned serving snapshot, so one reload moves every prediction path together and a request continues to see an internally consistent set of objects even if a reload lands mid-flight. Loaders that do not supply the URL pair keep working unchanged, so existing callers and lightweight test doubles are unaffected.
Test plan
Depends on
Stacked on #1038, #1039 and #1040. Their commits are included here, so this diff shrinks to just the reload-coverage changes once they merge.