feat(ml-api): split liveness/readiness probes and drain on shutdown - #1020
Merged
Userunknown84 merged 1 commit intoJul 29, 2026
Merged
Conversation
|
@pavsoss is attempting to deploy a commit to the Aditya Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
Userunknown84
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthwas a static{"status":"ok"}, so an orchestrator could route traffic to an instance that would fail every prediction, and SIGTERM dropped in-flight requests.GET /health/live— always 200 (process up).GET /health/ready— 200 only when the serving state is loaded and the spam-words DB and rate-limit store respond; otherwise 503 in the standard error envelope.GET /healthretained as a backward-compatible alias.Test plan
/health/liveis 200 independent of dependencies;/health/readyis 503 when the model isn't loaded / a dependency is down and 200 when healthy; entering drain flips readiness to 503;/healthbehaves as before.Closes #1009